-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21696] Fix Secure Discovery Server client disposals guid and handshake_handle assertion #5257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 16, 2024 11:24
JesusPoderoso
requested changes
Oct 17, 2024
test/dds/communication/security/multiple_secure_ds_pubsub_secure_crypto_communication.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
October 17, 2024 12:59
MiguelCompany
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a NIT
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues regarding
Secure Discovery Server
guid
was not beaing properly send from clients to server.SecurityManager
as a consequence of not being able to retrieve a new change in theparticipant_stateless_msg_writer
@Mergifyio backport 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist