Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21726] Regression test for Fast DDS-Gen Use different typename for collections of TK_UINT8 and TK_BYTE #5251

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 20, 2024

Description

This PR adds a regression test for changes in generated coded coming from eProsima/Fast-DDS-Gen#400

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 20, 2024
@richiware richiware changed the title Regression test for Fast DDS-Gen Use different typename for collections of TK_UINT8 and TK_BYTE [21726] Regression test for Fast DDS-Gen Use different typename for collections of TK_UINT8 and TK_BYTE Sep 20, 2024
Signed-off-by: Ricardo González Moreno <[email protected]>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added this to the v3.0.2 milestone Sep 23, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Sep 23, 2024
@richiware richiware merged commit ce8e4eb into master Sep 24, 2024
13 of 17 checks passed
@richiware richiware deleted the bugfix/20878 branch September 24, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants