Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/follow up/discard unreachable shm locators #5126

Closed
wants to merge 20 commits into from
Closed

Feature/follow up/discard unreachable shm locators #5126

wants to merge 20 commits into from

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Aug 2, 2024

Description

Follow up of #5118

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

EduPonz and others added 20 commits July 30, 2024 20:31
@EduPonz
Refs #19036: NetworkFactory.h -> NetworkFactory.hpp
fcf10bc 
Signed-off-by: eduponz <[email protected]>
@EduPonz
Refs #19036: Add NetworkFactory::is_locator_reachable API
ea8a5c3 
Signed-off-by: eduponz <[email protected]>
@EduPonz
Refs #19036: ProxyDataFilters::filter_locators delegates locator chec…
e4a8983 
…king to the NetworkFactory

Signed-off-by: eduponz <[email protected]>
@EduPonz
Refs #19036: NetworkFactory::is_locator_reachable iterates over the t…
efe02ca 
…ransports until one reports locator reachability

Signed-off-by: eduponz <[email protected]>
@EduPonz
Refs #19036: SharedMemTransport::is_locator_reachable discards non-sh…
b4833f6 
…m non-local ports, and shm local ports that cannot open to write

Signed-off-by: eduponz <[email protected]>
@elianalf @MiguelCompany
Refs #19036: Apply suggestions
170e8c4 
Signed-off-by: elianalf <[email protected]>
@MiguelCompany
Refs #19036. Increase MAX_DOMAIN_NAME_LENGTH and `CURRENT_ABI_VERSI…
8077a51 
…ON`.

Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #19036. Rename to creator_name.
c80f97e 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #19036. Port receives domain name on construction.
7459a23 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #19036. Use user name as part of the port ABI check.
7e2b522 
Signed-off-by: Miguel Company <[email protected]>
@elianalf
Revert "Refs #19036. Use user name as part of the port ABI check."
43b342e 
This reverts commit 7e2b522.
@elianalf
Revert "Refs #19036. Port receives domain name on construction."
ae9b825 
This reverts commit 7459a23.
@elianalf
Revert "Refs #19036. Rename to creator_name."
3f7839a 
This reverts commit c80f97e.
@elianalf
Revert "Refs #19036. Increase MAX_DOMAIN_NAME_LENGTH and `CURRENT_A…
3220dc1 
…BI_VERSION`."

This reverts commit 8077a51.
@elianalf
Refs #19036: Change the address sent in case of shm transport from ho…
bfb7538 
…st id to user name

Signed-off-by: elianalf <[email protected]>
@elianalf
Refs #19036: Uncrustify
15f49ab 
Signed-off-by: elianalf <[email protected]>
@elianalf
Refs #19036: Copy the user name in address starting from the second b…
298b3c7 
…yte because the first is used for unicast info

Signed-off-by: elianalf <[email protected]>
@elianalf
Refs #19036: Add network_mode: and host ipc: host to make the contain…
ef97318 
…ers communicate

Signed-off-by: elianalf <[email protected]>
@elianalf
Refs #19036: Solve build issue in windows
7d9d6b3 
Signed-off-by: elianalf <[email protected]>
@Mario-DL
use shm locator's addres MD5 mangling host id and user name
bcd5d61 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL added this to the v3.0.1 milestone Aug 2, 2024
@github-actions github-actions bot added ci-pending PR which CI is running labels Aug 2, 2024
@MiguelCompany MiguelCompany modified the milestones: v3.0.1, v3.0.2 Sep 4, 2024
@MiguelCompany MiguelCompany added to-do needs rebase and removed ci-pending PR which CI is running labels Oct 2, 2024
@MiguelCompany MiguelCompany removed this from the v3.0.2 milestone Oct 2, 2024
@MiguelCompany MiguelCompany added this to the v3.1.0 milestone Oct 2, 2024
@rsanchez15
Copy link
Contributor

We were closing this PR since we decided to follow a different approach.

@rsanchez15 rsanchez15 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
needs rebase to-do
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Mario-DL @rsanchez15 @MiguelCompany @EduPonz @elianalf