Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21364] Remove double // in some installation paths #5111

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[21364] Remove double // in some installation paths #5111

merged 1 commit into from
Jul 29, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 29, 2024 •
edited by elianalf
Loading

Description

Some installation paths contained a //, this PR fixes those, even though they are not harmful.

@Mergifyio backport 2.14.x

IMPORTANT: Same change needs to be backported to 2.10.x, but it'd be easier from the 2.14.x PR.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Jul 29, 2024
@EduPonz EduPonz added this to the v3.0.0 milestone Jul 29, 2024
@EduPonz EduPonz requested a review from elianalf July 29, 2024 07:56
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 29, 2024
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 29, 2024
@EduPonz EduPonz merged commit 8c477dc into master Jul 29, 2024
14 checks passed
@EduPonz EduPonz deleted the hotfix/installation_double_slash_path branch July 29, 2024 09:44
@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 2.14.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 5, 2024 •
edited
Loading

backport 2.14.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 5, 2024
@EduPonz @mergify
Remove double // in some installation paths (#5111)
8cfca68 
Signed-off-by: eduponz <[email protected]>
(cherry picked from commit 8c477dc)

# Conflicts:
#	CMakeLists.txt
@mergify mergify bot mentioned this pull request Aug 5, 2024
Merged
9 tasks
JesusPoderoso pushed a commit that referenced this pull request Sep 23, 2024
@EduPonz @JesusPoderoso
Remove double // in some installation paths (#5111)
6e52e76 
Signed-off-by: eduponz <[email protected]>
(cherry picked from commit 8c477dc)

# Conflicts:
#	CMakeLists.txt
MiguelCompany pushed a commit that referenced this pull request Sep 24, 2024
@mergify @EduPonz
Remove double // in some installation paths (#5111) (#5129)
28a2729 
Signed-off-by: eduponz <[email protected]>
(cherry picked from commit 8c477dc)

# Conflicts:
#	CMakeLists.txt

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
mergify bot added a commit that referenced this pull request Sep 24, 2024
@mergify
Remove double // in some installation paths (#5111) (#5129)
1a056ef 
Signed-off-by: eduponz <[email protected]>
(cherry picked from commit 8c477dc)

# Conflicts:
#	CMakeLists.txt

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
(cherry picked from commit 28a2729)
@mergify mergify bot mentioned this pull request Sep 24, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EduPonz @JesusPoderoso @elianalf