Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21096] Feature: use PID_DOMAIN_ID during PDP #4888

Merged
merged 11 commits into from
Jun 12, 2024
Merged

[21096] Feature: use PID_DOMAIN_ID during PDP #4888

merged 11 commits into from
Jun 12, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jun 3, 2024 •
edited by EduPonz
Loading

Description

This PR adds the PID_DOMAIN_ID parameter to the PDP discovery phase with the following considerations:

  • PID_DOMAIN_ID is always sent.
  • In PDPSimple, domains have either to be the same or not be defined in the remote incoming ParticipantProxyData.
  • In Discovery Server we do not check the parameter since it is meant to operate across domains.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • NO New feature has been documented/Current behavior is correctly described in the documentation.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jun 3, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 3, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima June 3, 2024 09:30
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jun 3, 2024
@Mario-DL Mario-DL requested review from richiprosima and EduPonz and removed request for richiprosima June 3, 2024 10:32
@Mario-DL
Copy link
Member Author

Mario-DL commented Jun 5, 2024

@richiprosima please test_3 discovery-server

1 similar comment
@Mario-DL
Copy link
Member Author

Mario-DL commented Jun 6, 2024

@richiprosima please test_3 discovery-server

@Mario-DL Mario-DL requested review from EduPonz and removed request for EduPonz June 6, 2024 05:48
EduPonz
EduPonz suggested changes Jun 8, 2024
View reviewed changes
include/fastdds/dds/core/policy/ParameterTypes.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/core/Types.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/core/policy/ParameterSerializer.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/core/policy/ParameterSerializer.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/core/policy/ParameterSerializer.hpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsDiscovery.cpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsDiscovery.cpp Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsDiscovery.cpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsMonitorService.cpp Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDPClientListener.hpp Outdated Show resolved Hide resolved
@Mario-DL Mario-DL force-pushed the feature/21096 branch 2 times, most recently from c14badd to e2a35ff Compare June 10, 2024 10:01
@Mario-DL Mario-DL requested a review from EduPonz June 10, 2024 10:02
@Mario-DL
Copy link
Member Author

@richiprosima please test_3 discovery-server

@EduPonz EduPonz added skip-ci Automatically pass CI versions-pending and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Jun 11, 2024
EduPonz
EduPonz suggested changes Jun 11, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI too. I think the only thing left here is to add this to the versions.md file (remember to update the PR checklist)

@Mario-DL Mario-DL removed skip-ci Automatically pass CI versions-pending labels Jun 11, 2024
@Mario-DL Mario-DL requested a review from EduPonz June 11, 2024 08:37
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 11, 2024
EduPonz
EduPonz previously approved these changes Jun 11, 2024
View reviewed changes
@EduPonz
Copy link

EduPonz commented Jun 11, 2024

@richiprosima please test_3 discovery-server

@Mario-DL Mario-DL requested a review from EduPonz June 12, 2024 06:18
@Mario-DL
Copy link
Member Author

@richiprosima please test_3 discovery-server

EduPonz
EduPonz previously approved these changes Jun 12, 2024
View reviewed changes
@EduPonz EduPonz added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Jun 12, 2024
@Mario-DL @EduPonz
Refs #21096: Extend test transport configuration
84b7b7e 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Add BB tests
bb89c2c 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Little fixes on existing unittests an BB tests
c4c22b8 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Implementation
60f36d8 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Linter
07b1b72 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Prevent undefined behavior initializing variables in tes…
38a2c23 
…t_transport

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Specialize check_discovery_conditions() in PDPSecurityIn…
7b874a6 
…itiator DS listener

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Fix cyclone dds participant discovery test. Match the do…
58320c4 
…mains

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Applied Edus review
34fcb73 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: versions.md
c983740 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL @EduPonz
Refs #21096: Add PDPClientListener.cpp to statefulreadertests
d69673f 
Signed-off-by: Mario Dominguez <[email protected]>
@EduPonz EduPonz self-requested a review June 12, 2024 17:19
@EduPonz EduPonz merged commit 150941f into master Jun 12, 2024
6 checks passed
@EduPonz EduPonz deleted the feature/21096 branch June 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @EduPonz @elianalf