Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20339] Migrate TCPReqRepHelloWorldReplier/Requester #4296

Merged
merged 5 commits into from
Feb 28, 2024
Merged

[20339] Migrate TCPReqRepHelloWorldReplier/Requester #4296

merged 5 commits into from
Feb 28, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jan 26, 2024 •
edited by EduPonz
Loading

Description

This pr:

  • Migrate TCPReqRepHelloWorldReplier/Requester from test/blackbox/common to test/blackbox/api/dds/dds-pim.
  • Substitute the old APIs with the new ones.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jan 26, 2024
@elianalf elianalf force-pushed the release-v3/migrate_reqrep_tcp_test_api branch from c5c73c4 to 420c938 Compare January 26, 2024 10:05
@JLBuenoLopez JLBuenoLopez force-pushed the feature/3.0.x branch 2 times, most recently from 22912a5 to 9c63223 Compare January 30, 2024 14:43
@elianalf elianalf changed the title Migrate TCPReqRepHelloWorldReplier/Requester [20339] Migrate TCPReqRepHelloWorldReplier/Requester Jan 31, 2024
@elianalf elianalf force-pushed the feature/3.0.x branch 3 times, most recently from ade136b to 51c21ef Compare February 12, 2024 06:59
@JLBuenoLopez JLBuenoLopez force-pushed the feature/3.0.x branch 4 times, most recently from a1a1614 to 13abfb4 Compare February 22, 2024 06:52
@elianalf elianalf force-pushed the release-v3/migrate_reqrep_tcp_test_api branch from 420c938 to b7b0e55 Compare February 22, 2024 08:46
@elianalf elianalf changed the base branch from feature/3.0.x to master February 22, 2024 08:48
@elianalf elianalf force-pushed the release-v3/migrate_reqrep_tcp_test_api branch from b7b0e55 to ef91548 Compare February 22, 2024 08:50
@EduPonz EduPonz modified the milestones: v3.0.0, v2.14.0 Feb 26, 2024
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Feb 27, 2024
@elianalf elianalf force-pushed the release-v3/migrate_reqrep_tcp_test_api branch from 8be333b to db7e2b7 Compare February 27, 2024 08:19
@elianalf
Copy link
Contributor Author

@richiprosima please test this

JesusPoderoso
JesusPoderoso approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elianalf elianalf force-pushed the release-v3/migrate_reqrep_tcp_test_api branch from db7e2b7 to 288f47a Compare February 27, 2024 10:33
@elianalf
Copy link
Contributor Author

@richiprosima please test this

@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Feb 28, 2024
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label Feb 28, 2024
@EduPonz EduPonz merged commit e136aab into master Feb 28, 2024
12 of 17 checks passed
@EduPonz EduPonz deleted the release-v3/migrate_reqrep_tcp_test_api branch February 28, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @JesusPoderoso @EduPonz