Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new Fast-CDR v2.0.0 [19456] #3828

Merged
merged 41 commits into from
Sep 27, 2023
Merged

Support new Fast-CDR v2.0.0 [19456] #3828

merged 41 commits into from
Sep 27, 2023

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 6, 2023 •
edited by JLBuenoLopez
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [NO] Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: Documentation about Fast-CDR v2.0.0 and new annotations [19458] Fast-DDS-docs#550
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Support new Fast-CDR v2.0.0 Support new Fast-CDR v2.0.0 [19456] Sep 6, 2023
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 8, 2023
Merged
5 tasks
@richiware richiware mentioned this pull request Sep 8, 2023
Closed
6 tasks
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 8, 2023
Closed
1 task
@EduPonz EduPonz mentioned this pull request Sep 9, 2023
Merged
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 12, 2023
Closed
@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test this

1 similar comment
@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test linux

@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test linux

MiguelCompany
MiguelCompany previously requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top-level CMakeLists.txt should be updated to require fastcdr version above v2

@JLBuenoLopez JLBuenoLopez added this to the v2.12.0 milestone Sep 13, 2023
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 13, 2023
Closed
13 tasks
JLBuenoLopez
JLBuenoLopez suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First partial review. Still a lot to review

examples/cpp/dds/ContentFilteredTopicExample/MyCustomFilter.hpp Outdated Show resolved Hide resolved
fastrtps.repos Outdated Show resolved Hide resolved
fastrtps.repos Outdated Show resolved Hide resolved
fastrtps.repos Outdated Show resolved Hide resolved
fastrtps.repos Outdated Show resolved Hide resolved
src/cpp/dynamic-types/TypeObject.cpp Outdated Show resolved Hide resolved
src/cpp/dynamic-types/TypeObject.cpp Outdated Show resolved Hide resolved
src/cpp/dynamic-types/TypeObjectFactory.cpp Outdated Show resolved Hide resolved
src/cpp/dynamic-types/TypeObjectHashId.cpp Outdated Show resolved Hide resolved
src/cpp/dynamic-types/TypesBase.cpp Outdated Show resolved Hide resolved
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 15, 2023
Closed
1 task
JLBuenoLopez
JLBuenoLopez reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review until commit 4804ba68f8c913dec2fe3debada6944b34cabed4

src/cpp/fastdds/builtin/common/RPCHeadersImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/builtin/common/RPCHeadersImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/builtin/common/RPCHeadersImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/builtin/common/RPCHeadersImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/builtin/typelookup/TypeLookupManager.cpp Outdated Show resolved Hide resolved
test/realtime/UserThreadNonBlockedTest.cpp Outdated Show resolved Hide resolved
test/realtime/UserThreadNonBlockedTest.cpp Outdated Show resolved Hide resolved
test/unittest/dynamic_types/DynamicComplexTypesTests.cpp Outdated Show resolved Hide resolved
test/unittest/dynamic_types/DynamicTypes_4_2_Tests.cpp Outdated Show resolved Hide resolved
test/unittest/dynamic_types/DynamicTypes_4_2_Tests.cpp Outdated Show resolved Hide resolved
@richiware
Copy link
Member Author

The top-level CMakeLists.txt should be updated to require fastcdr version above v2

@MiguelCompany done in 006e71401

@richiware
Copy link
Member Author

@richiprosima please test this

@JesusPoderoso JesusPoderoso mentioned this pull request Sep 18, 2023
Merged
7 tasks
@richiware
Copy link
Member Author

@richiprosima please test this

JLBuenoLopez
JLBuenoLopez reviewed Sep 19, 2023
View reviewed changes
include/fastrtps/types/TypeObject.h Outdated Show resolved Hide resolved
include/fastdds/dds/topic/TopicDataType.hpp Outdated Show resolved Hide resolved
test/blackbox/types/Data1mbPubSubTypes.h Outdated Show resolved Hide resolved
fastrtps.repos Outdated Show resolved Hide resolved
@JesusPoderoso JesusPoderoso mentioned this pull request Sep 19, 2023
Merged
9 tasks
JLBuenoLopez
JLBuenoLopez reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of comments regarding the TypeObject types...

Also, I think the versions.md should be updated with the API break in MEMBER_INVALID. I have updated the checklist including the N/A points. Check if you agree.

src/cpp/dynamic-types/TypeObjectCdrAux.ipp Outdated Show resolved Hide resolved
src/cpp/dynamic-types/TypeObjectCdrAux.ipp Outdated Show resolved Hide resolved
src/cpp/dynamic-types/TypesBase.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/transport/tcp/TCPControlMessage.cpp Outdated Show resolved Hide resolved
test/blackbox/common/RTPSAsSocketReader.hpp Outdated Show resolved Hide resolved
test/blackbox/common/RTPSAsSocketWriter.hpp Outdated Show resolved Hide resolved
@JLBuenoLopez JLBuenoLopez added the ci-pending PR which CI is running label Sep 20, 2023
@richiware
Refs #18687. Fix warning on mac
7d0278c 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Refs #18687. Remove Benchmark example
eb78332 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member Author

@richiprosima please test this

1 similar comment
@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test mac

3 similar comments
@richiware
Copy link
Member Author

@richiprosima please test mac

@richiware
Copy link
Member Author

@richiprosima please test mac

@richiware
Copy link
Member Author

@richiprosima please test mac

@richiware
Refs #18687. Trying compile VS2017
042ac9a 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member Author

@richiprosima please test this

3 similar comments
@richiware
Copy link
Member Author

@richiprosima please test this

@EduPonz
Copy link

EduPonz commented Sep 26, 2023

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test this

@richiware richiware force-pushed the feature/xcdr branch 3 times, most recently from 6849cee to 22a5ed4 Compare September 27, 2023 05:40
@richiware
Refs #18687. Fix warnings after upgrade clang
9c76dcc 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member Author

@richiprosima please test this

JLBuenoLopez
JLBuenoLopez reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last minute changes! In order to improve the release process I think that we should take into account the following in the future:

  1. The infrastructure should be updated periodically. Maybe this could be done a month before the release date (but never in the same week).
  2. If a new tool has to be installed in such a short notice, it is important to look into the tool's dependencies and take into account that if some development tool is upgraded, the tool should not be installed until after the release.

src/cpp/utils/md5.cpp Show resolved Hide resolved
@JLBuenoLopez JLBuenoLopez removed the ci-pending PR which CI is running label Sep 27, 2023
JLBuenoLopez
JLBuenoLopez approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit 4204d41 into master Sep 27, 2023
7 of 13 checks passed
@richiware richiware deleted the feature/xcdr branch September 27, 2023 09:16
@JLBuenoLopez JLBuenoLopez restored the feature/xcdr branch October 5, 2023 06:11
@JLBuenoLopez JLBuenoLopez mentioned this pull request Nov 13, 2023
Merged
7 tasks
@clalancette clalancette mentioned this pull request Jan 18, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

@MiguelCompany MiguelCompany MiguelCompany left review comments

Assignees
No one assigned
Labels
first-to-merge
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@richiware @JLBuenoLopez @EduPonz @MiguelCompany