Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix real-time in Flow Controller #3735

Merged
merged 14 commits into from
Sep 13, 2023
Merged

Fix real-time in Flow Controller #3735

merged 14 commits into from
Sep 13, 2023

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 20, 2023 •
edited by MiguelCompany
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test linux

@richiware
Copy link
Member Author

@richiprosima please test mac

@EduPonz EduPonz added this to the v2.12.0 milestone Aug 11, 2023
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Aug 18, 2023
@richiware
Copy link
Member Author

@richiprosima please test this

1 similar comment
@richiware
Copy link
Member Author

@richiprosima please test this

@richiware richiware force-pushed the bugfix/flowcontroller-realtime branch from 0ed5df7 to 0de066d Compare August 31, 2023 05:55
@richiware
Copy link
Member Author

@richiprosima please test this

@richiware richiware closed this Aug 31, 2023
@richiware richiware reopened this Aug 31, 2023
@richiware
Copy link
Member Author

@richiprosima please test this

2 similar comments
@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test this

@richiware
Copy link
Member Author

@richiprosima please test mac

MiguelCompany
MiguelCompany requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review: headers and source. Pending review of tests.

include/fastdds/rtps/history/WriterHistory.h Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterHistory.cpp Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterHistory.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/subscriber/history/DataReaderHistory.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/history/History.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/history/History.cpp Show resolved Hide resolved
src/cpp/rtps/history/ReaderHistory.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/history/WriterHistory.cpp Show resolved Hide resolved
@richiware
Refs #13803. Fix realtime in flowcontroller
ff4f100 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #13803. Fix error
0ff65eb 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #13803. Update realtime tests to DDS API
d682b8b 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #13803. Fix blocking lock when removing from flowcontroller
ee10cdd 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #13803. Fix compilation without STRICT_REALTIME
18c4884 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Fix bug in readers
5302661 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Document tests
be5a025 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Improve doxygen documentation
5ad701b 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Fix bug in readers
fed60d1 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Fix warning on windows
ae9da6c 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Apply suggestion
8a78720 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Apply suggestion
280d1a7 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Apply suggestions
5c16b98 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19254. Apply suggestions
db1bca5 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member Author

@richiprosima please test this

MiguelCompany
MiguelCompany approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed labels Sep 12, 2023
@richiware
Copy link
Member Author

@richiprosima please test mac

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Sep 13, 2023
@MiguelCompany MiguelCompany merged commit a575bbb into master Sep 13, 2023
7 of 8 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/flowcontroller-realtime branch September 13, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@richiware @MiguelCompany @EduPonz @JesusPoderoso