Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18910] Temporal fix for 3361 Regression test types and regeneration with Fast DDS Gen 2.5.1 #3634

Closed
wants to merge 2 commits into from

Conversation

Mario-DL
Copy link
Member

This PR regenerates the TestRegression3361... types with Fast DDS Gen 2.5.1 with the -typeobject arg and proposes a temporal fix for a mistaken #include in one of the generated files.

Another solution would be ignoring the TestRegression3361.idl temporarily by appending it to the files_to_exclude()
update_generated_code_from_idl.sh automation script array. Opening it as a draft for the moment.

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Jun 28, 2023
@Mario-DL Mario-DL changed the title Bugfix/types regression 3361 [18910] Temporal fix for 3361 Regression test types Jun 28, 2023
@Mario-DL Mario-DL changed the title [18910] Temporal fix for 3361 Regression test types [18910] Temporal fix for 3361 Regression test types and regeneration with Fast DDS Gen 2.5.1 Jun 28, 2023
@Mario-DL Mario-DL mentioned this pull request Jun 28, 2023
5 tasks
@JLBuenoLopez
Copy link
Contributor

I am closing this PR as #3828 is already taking care of that and using the latest version of Fast DDS-Gen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants