Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21783] Add notes for Fast DDS v3.1.0 #930

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[21783] Add notes for Fast DDS v3.1.0 #930

merged 2 commits into from
Oct 11, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 10, 2024 •
edited by JesusPoderoso
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL Mario-DL added this to the v3.1.0 milestone Oct 10, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 10, 2024 14:43
JesusPoderoso

This comment was marked as resolved.

Sign in to view

@Mario-DL
Refs #21783: Apply Jesus review
cbfc4a9 
Signed-off-by: Mario Dominguez <[email protected]>
JesusPoderoso
JesusPoderoso approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL merged commit 922d5b1 into master Oct 11, 2024
4 checks passed
@Mario-DL Mario-DL deleted the docs/3.1.0/release-notes branch October 11, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @JesusPoderoso