Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21655] Add default subscriber profile in ROS 2 XML configuration #910

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[21655] Add default subscriber profile in ROS 2 XML configuration #910

merged 1 commit into from
Sep 19, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 13, 2024 •
edited by richiware
Loading

Description

This PR adds the default subscriber profile in ROS 2 XML configuration snippet. This is particularly interesting for 2.6.x as if the default profile defaults readers historymemroypolicy to PREALLOCATED.

@Mergifyio backport 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL Mario-DL added this to the v3.0.2 milestone Sep 13, 2024
@richiware richiware self-requested a review September 19, 2024 07:55
@richiware richiware merged commit 6e60196 into master Sep 19, 2024
4 checks passed
@richiware richiware deleted the docs/21655 branch September 19, 2024 09:20
@Mario-DL
Copy link
Member Author

@Mergifyio backport 2.14.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Sep 19, 2024 •
edited
Loading

backport 2.14.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@Mario-DL @mergify
Add default subscriber profile in ROS 2 XML configuration (#910)
5a3008a 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e60196)
@mergify mergify bot mentioned this pull request Sep 19, 2024
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@Mario-DL @mergify
Add default subscriber profile in ROS 2 XML configuration (#910)
34831a8 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e60196)
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@Mario-DL @mergify
Add default subscriber profile in ROS 2 XML configuration (#910)
71bddc9 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e60196)
This was referenced Sep 19, 2024
Merged
Open
MiguelCompany pushed a commit that referenced this pull request Sep 19, 2024
@mergify @Mario-DL
Add default subscriber profile in ROS 2 XML configuration (#910) (#914)
3f06802 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e60196)

Co-authored-by: Mario Domínguez López <[email protected]>
JesusPoderoso pushed a commit that referenced this pull request Sep 19, 2024
@mergify @Mario-DL
Add default subscriber profile in ROS 2 XML configuration (#910) (#913)
222670b 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 6e60196)

Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @richiware