Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21114] Check suprocess return codes on RDT generation (backport #795) #799

Open
wants to merge 1 commit into
base: 2.6.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 5, 2024

Description

This PR makes the RDT generation to fail if either of the doxygen or swig commands fails. Not checking them was causing the documentation to build with API reference errors.

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Related implementation PR:

NOTE: As RTD build is not ready to take the appropriate Fast DDS branch and will choose master, the build will failed until eProsima/Fast-DDS#4896 is merged. I've verified on a Ubuntu 20.04 docker that the doxygen is generated without errors with that Fast DDS PR.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #795 done by [Mergify](https://mergify.com).

@JesusPoderoso JesusPoderoso added this to the v2.6.9 milestone Jun 5, 2024
@Mario-DL Mario-DL closed this Jun 27, 2024
@Mario-DL Mario-DL reopened this Jun 27, 2024
Signed-off-by: eduponz <[email protected]>
(cherry picked from commit 0974196)
@Mario-DL
Copy link
Member

@richiprosima please test docs

@Mario-DL Mario-DL added to-do and removed ci-pending labels Jun 27, 2024
@EduPonz
Copy link

EduPonz commented Jul 3, 2024

This shall include changes similar to those introduced in:

@Mario-DL Mario-DL modified the milestones: v2.6.9, v2.6.10 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants