Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19583] Add documentation for environment variables expansion on XML #556

Merged
merged 3 commits into from
Sep 20, 2023
Merged

[19583] Add documentation for environment variables expansion on XML #556

merged 3 commits into from
Sep 20, 2023

Conversation

MiguelCompany
Copy link
Member

This PR adds documentation for the feature introduced by eProsima/Fast-DDS#3841

@MiguelCompany MiguelCompany mentioned this pull request Sep 19, 2023
Merged
12 tasks
@MiguelCompany MiguelCompany added this to the v2.12.0 milestone Sep 19, 2023
EduPonz
EduPonz suggested changes Sep 19, 2023
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shall document:

  1. Limitations on env var names
  2. That it is possible to mix text and multiple env vars

@EduPonz EduPonz merged commit c29cd6e into master Sep 20, 2023
4 checks passed
@EduPonz EduPonz deleted the feature/xml-environment branch September 20, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz