Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grade Publishing Reminder Email in send_reminders #2284

Merged
merged 18 commits into from
Oct 7, 2024
Merged

Grade Publishing Reminder Email in send_reminders #2284

merged 18 commits into from
Oct 7, 2024

Conversation

richardebeling
Copy link
Member

fixes #2087

Also does some other stuff, probably best reviewed by commit.

janno42
janno42 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📆 remind all the people!

niklasmohrin
niklasmohrin reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a hunch that we should use "grade_publishing_reminder" everywhere instead of just "grade_reminder". Otherwise, nicely done

evap/settings.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/tests/test_models.py Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

evap/evaluation/models.py Show resolved Hide resolved
evap/evaluation/tools.py Outdated Show resolved Hide resolved
evap/development/fixtures/test_data.json Show resolved Hide resolved
@richardebeling richardebeling merged commit bfd3d4b into e-valuation:main Oct 7, 2024
10 of 12 checks passed
@richardebeling richardebeling deleted the grade-reminder branch October 7, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@janno42 janno42 janno42 approved these changes

@Kakadus Kakadus Awaiting requested review from Kakadus

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic Grade Publishing Reminder
4 participants
@richardebeling @janno42 @niklasmohrin @Kakadus