Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add participant progress bar #2234

Merged
merged 33 commits into from
Jul 7, 2024
Merged

Add participant progress bar #2234

merged 33 commits into from
Jul 7, 2024

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented Jun 28, 2024 •
edited by janno42
Loading

close #2233

Open things:

  • collapsible text
  • last evaluation time (NEXT to text)
  • translations
  • refactor (esp. to avoid else: case)
  • tests

@Kakadus Kakadus changed the title hack first version of participant progress bar Add participant progress bar Jun 28, 2024
@janno42 janno42 marked this pull request as draft June 28, 2024 16:50
@janno42 janno42 marked this pull request as draft June 28, 2024 16:50
richardebeling
richardebeling reviewed Jun 29, 2024
View reviewed changes
evap/settings.py Outdated Show resolved Hide resolved
evap/settings.py Outdated Show resolved Hide resolved
evap/student/views.py Outdated Show resolved Hide resolved
evap/student/views.py Outdated Show resolved Hide resolved
evap/student/views.py Outdated Show resolved Hide resolved
evap/student/views.py Outdated Show resolved Hide resolved
evap/student/views.py Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
@richardebeling richardebeling marked this pull request as ready for review June 30, 2024 17:02
niklasmohrin
niklasmohrin reviewed Jun 30, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, mostly code style comments

Why does is the bar full when 90% are reached? Wouldn't it be nicer if the students could still strive for >90% (or the epic gaming move of going 100%), even if all rewards are reached?

deployment/localsettings.template.py Outdated Show resolved Hide resolved
deployment/localsettings.template.py Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
deployment/localsettings.template.py Outdated Show resolved Hide resolved
evap/student/views.py Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
evap/student/templates/student_index.html Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin approved these changes Jul 3, 2024
View reviewed changes
evap/student/tests/test_views.py Outdated Show resolved Hide resolved
evap/static/scss/components/_progress.scss Outdated Show resolved Hide resolved
evap/static/scss/_mixins.scss Show resolved Hide resolved
evap/student/templates/student_global_reward.html Outdated Show resolved Hide resolved
Kakadus
Kakadus commented Jul 7, 2024
View reviewed changes
Copy link
Collaborator Author

@Kakadus Kakadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

evap/evaluation/templatetags/evaluation_filters.py Outdated Show resolved Hide resolved
@Kakadus Kakadus merged commit 25cd3a0 into e-valuation:main Jul 7, 2024
12 checks passed
@Kakadus Kakadus deleted the feat-current-evaluation-progress branch July 7, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 janno42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Participation progress bar
4 participants
@Kakadus @janno42 @richardebeling @niklasmohrin