Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink RatingResult class names #2102

Open
Kakadus opened this issue Jan 15, 2024 · 0 comments
Open

Rethink RatingResult class names #2102

Kakadus opened this issue Jan 15, 2024 · 0 comments
Labels
Discussion This issue requires some discussion and a decision what a solution might look like.

Comments

@Kakadus
Copy link
Collaborator

Kakadus commented Jan 15, 2024 •
edited by richardebeling
Loading

The class names are not very intuitive to me. Can we find a short comment explaining these names that we can add here? I think the last state was "This is what the code currently has, we don't really have a good argument why" 😅

Originally posted by @richardebeling in #2091 (comment)
@janno42 janno42 added the Discussion This issue requires some discussion and a decision what a solution might look like. label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion This issue requires some discussion and a decision what a solution might look like.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janno42 @Kakadus