Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook layouting compatibility with high DPI / widescreen displays #2098

Open
richardebeling opened this issue Jan 8, 2024 · 0 comments
Open
Labels
[C] Frontend Focuses on frontend implementation [P] Minor Minor priority [S] Small This issue should require only small changes.

Comments

@richardebeling
Copy link
Member

The current notebook breakpoints used to determine whether the layout should be top/bottom or left/right doesn't consider the content width limit that the page otherwise has. On High-DPI or widescreen monitors, this can easily lead to cases where the top/bottom layout is used although the left/right layout would be more appropriate.

This is what currently happens when you zoom out of the page far enough:
image

I think we might want to

  • Limit the width of the notebook in top/bottom mode to the same width as the content of the page
  • Use the limited content width for calculating whether the media breakpoint is hit or not (instead of the viewport width, which we currently use)
@richardebeling richardebeling added [C] Frontend Focuses on frontend implementation [S] Small This issue should require only small changes. labels Jan 8, 2024
@janno42 janno42 added the [P] Minor Minor priority label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Frontend Focuses on frontend implementation [P] Minor Minor priority [S] Small This issue should require only small changes.
Development

No branches or pull requests

2 participants