Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling same chain ID non rollapp and rollapp #1241

Open
danwt opened this issue Sep 21, 2024 · 0 comments
Open

Fix handling same chain ID non rollapp and rollapp #1241

danwt opened this issue Sep 21, 2024 · 0 comments

Comments

@danwt
Copy link
Contributor

danwt commented Sep 21, 2024

It's specifically with this code

chainID, err := uibc.ChainIDFromPortChannel(ctx, k.channelKeeper, raPortOnHub, raChanOnHub)
if err != nil {
return nil, errorsmod.Wrap(err, "chain id from port and channel")
}
rollapp, ok := k.GetRollapp(ctx, chainID)
if !ok {
return nil, errorsmod.Wrapf(errRollappNotFound, "chain id: %s: port: %s: channel: %s", chainID, raPortOnHub, raChanOnHub)
}

We are assuming a rollapp cannot have same ID as a non rollapp, which means we treat non rollapp as rollapp, wrongly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant