Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve handling of buffer type in JSON encoded structs #5

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Sep 6, 2024

  • Uses base64 for encoding/decoding buffer values in JSON encoded structs, unfortunately extism_convert::Base64 doesn't work here since it doesn't implement serde::{Serialize, Deserialize}
  • Updates xtp-bindgen so we can use the built-in camelToSnakeCase and capitalize functions

@nilslice
Copy link
Member

nilslice commented Sep 7, 2024

This LGTM! I'm just going add a new test to the bindgen suite to check the round-trip and then re-run from here.

@zshipko zshipko merged commit cef7d1e into main Sep 13, 2024
1 check passed
@zshipko zshipko deleted the buffer-tweaks branch September 13, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants