Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force docusaurus project to use npm #581

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Force docusaurus project to use npm #581

merged 4 commits into from
Oct 16, 2024
+17,253 −9,957

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Oct 16, 2024 •
edited
Loading

  • We were missing package-lock.json which i think cloudflare checks the presence of to decide to use npm over yarn
  • Added yarn.lock to .gitignore. I think trying to support yarn will just bring us heartache. we use this strategy in our other docusaurus deployments.
  • Updated the CI to use npm over yarn

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024 •
edited
Loading

Deploying chicory with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4059507
Status: ✅  Deploy successful!
Preview URL: https://df01ff87.chicory.pages.dev
Branch Preview URL: https://add-yarn-lock-to-gitignore.chicory.pages.dev

View logs

@bhelx bhelx mentioned this pull request Oct 16, 2024
Closed
andreaTP
andreaTP approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can try and see if this setup works for us.

@bhelx bhelx merged commit 2b3a897 into main Oct 16, 2024
22 checks passed
@bhelx bhelx deleted the add-yarn-lock-to-gitignore branch October 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhelx @andreaTP