Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies and enforce usage #470

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Cleanup dependencies and enforce usage #470

merged 1 commit into from
Aug 19, 2024

Conversation

electrum
Copy link
Collaborator

@electrum electrum commented Aug 18, 2024 •
edited
Loading

Ensure that

  • we declare all dependencies that are used
  • we do not declare unused dependencies (only declare dependencies that are used)

@electrum electrum mentioned this pull request Aug 18, 2024
Merged
andreaTP
andreaTP approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@andreaTP andreaTP merged commit d9d7aa8 into dylibso:main Aug 19, 2024
13 checks passed
andreaTP pushed a commit that referenced this pull request Aug 19, 2024
@electrum
Sort dependencies and modules in POM (#471)
0881fad 
This PR is on top of #470.
@electrum electrum deleted the deps branch August 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

@andreaTP andreaTP andreaTP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@electrum @bhelx @andreaTP