Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type validation use Module instead of Instance #465

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

electrum
Copy link
Collaborator

After #460 is merged, we can make this part of Module.Builder.

@electrum electrum requested a review from andreaTP August 14, 2024 01:48
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this, lgtm as soon as CI is green.
Going to merge #460 asap (we can iterate on top).

@electrum electrum force-pushed the validator branch 3 times, most recently from 0ed1a69 to f7c0224 Compare August 14, 2024 18:03
@electrum
Copy link
Collaborator Author

@andreaTP Thanks, rebased and updated

Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@electrum electrum merged commit b575891 into dylibso:main Aug 14, 2024
13 checks passed
@electrum electrum deleted the validator branch August 14, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants