Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Get more specs to pass #42

Merged
merged 5 commits into from
Oct 16, 2023
Merged

test: Get more specs to pass #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de9c79f
test: add stack.wast spec
bhelx Oct 15, 2023
467f94e
feat: add fac.wast
bhelx Oct 15, 2023
4625fdc
test: Add data.wast
bhelx Oct 15, 2023
8528c81
test: Add forward.wast
bhelx Oct 15, 2023
4c2c2fa
test: add float_literals.wast
bhelx Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,18 @@
align.wast,
int_literals.wast,
int_exprs.wast,
endianness.wast</wastToProcess>
endianness.wast,
fac.wast,
data.wast,
forward.wast,
float_literals.wast</wastToProcess>
<orderedWastToProcess>memory_grow.wast,
memory_size.wast</orderedWastToProcess>
memory_size.wast,
stack.wast</orderedWastToProcess>
<excludedTests>
<!-- Assertion failures -->
SpecV1MemoryGrowTest.test67,
SpecV1FacTest.test4,
<!-- call indirect failures -->
SpecV1MemoryGrowTest.test64,
SpecV1MemoryGrowTest.test65,
Expand Down
3 changes: 2 additions & 1 deletion test-gen-plugin/src/main/java/com/dylibso/chicory/maven/JavaTestGen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ public CompilationUnit generate(
// }
break;
default:
log.info("command type not yet supported " + cmd.getType());
// TODO we need to implement all of these
log.info("TODO: command type not yet supported " + cmd.getType());
// throw new IllegalArgumentException(
// "command type not yet supported " +
// cmd.getType());
Expand Down
2 changes: 2 additions & 0 deletions test-gen-plugin/src/main/java/com/dylibso/chicory/maven/wast/CommandType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ public enum CommandType {
ASSERT_MALFORMED("assert_malformed"),
@JsonProperty("assert_uninstantiable")
ASSERT_UNINSTANTIABLE("assert_uninstantiable"),
@JsonProperty("assert_exhaustion")
ASSERT_EXHAUSTION("assert_exhaustion"),
@JsonProperty("action")
ACTION("action");

Expand Down
6 changes: 3 additions & 3 deletions wasm/src/main/java/com/dylibso/chicory/wasm/types/Table.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
public class Table {
private ElementType elementType;
private long limitMin;
private long limitMax;
private Long limitMax;

public Table(ElementType elementType, long limitMin, long limitMax) {
public Table(ElementType elementType, long limitMin, Long limitMax) {
this.elementType = elementType;
this.limitMin = limitMin;
this.limitMax = limitMax;
Expand All @@ -19,7 +19,7 @@ public long getLimitMin() {
return limitMin;
}

public long getLimitMax() {
public Long getLimitMax() {
return limitMax;
}
}