Reduce 349 #355
Open
Reduce 349 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still need to fix the Chicory CLI output to match |
bhelx
approved these changes
May 30, 2024
electrum
reviewed
May 31, 2024
| @@ -321,6 +321,17 @@ public void issue294_BRTABLE() { | |||
| assertEquals(4, main.apply()[0].asInt()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void fuzzCrashReproY4ye0lx() { | |||
There was a problem hiding this comment.
I'm confused. What is this supposed to test? Since all the tests pass, it's not crashing.
There was a problem hiding this comment.
This test demonstrates that the interpreter is emitting the correct result, and the problem is in "mimicking" the wasmtime output.
I will follow up on this eventually, I'm considering moving to wasm-interp as an "Oracle" as it has a better handling of Wasm types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for 2 reasons:
wasm-interpfrom the wabt tools to compare with the bare result of ChicorySupersede #349