404 Error after attempting to authenticate through Github

[LuchoTurtle]

I was trying to authenticate with Github this morning so I could add a task to myself and I got a 404 Not Found error.

After refreshing the website, it now seems the WHOLE web app is down. No URL paths apparently work 😦

[nelsonic]

@LuchoTurtle thank you very much for opening this issue. 🔥
Please try this again in Safari on your Mac so that we can isolate the variables. 🙏
You appear to have a few Chrome plugins installed we need to test without any "interference". 💻
Report back with your progress. 👍

[LuchoTurtle]

Spot on, you're right. It seems that some of my extensions were the cause of it. It appears to be working on an incognito tab. Closing this issue as not relevant anymore.

[nelsonic]

We've had issues with random Chrome Plugins in places I've worked in the past including with React or Angular projects. So it's the first thing I think of when I see issues like this. 💭

Glad you got it working. Your feedback on the MVP is very valuable/valued to us! 🙏

[nelsonic]

@LuchoTurtle thank you for updating the title and re-opening the issue. ♻️
We need to investigate this ASAP. Should I bring my laptop to your desk and we pair on debugging this? 💻 🔥

[LuchoTurtle]

Turns out it's not plugin-related. You can replicate my issue by:

1. Going to mvp.fly.dev.
2. Logging in through Github

3. After logging in, the 404 error props up.

4. Now the whole website is down 😦 .

This happens in Safari as well. You can replicate this with an incognito window on Chrome.

[LuchoTurtle]

Sure let's do it @nelsonic

[nelsonic]

Noted. Just opening an issue for Stephany to work on in the next hour. will be right with you. Hopefully you have something else e.g: dwyl/phoenix-chat-example#54 you can look at in the mean time. 🤞

[nelsonic]

Let's take a look at this now. 🧑‍💻 ⏳ 🔥

[LuchoTurtle]

Just tried with Google Auth and got the following error:

Even worse than the 404 ... 🤦

[nelsonic]

That's super lame. I cannot replicate it in any browser on my machine.

But I do see this "Edit Profile" wall:

Which is another issue I want to address immediately after this one: #172

@LuchoTurtle if you have time now, I could open the Fly.io Logs for both the MVP and auth and we can attempt to debug this. 🧑‍💻

[nelsonic]

OK, I'm able to replicate the 404 in a private Safari session: ⛔

It appears that the auth redirect is no longer working 🤷‍♂️
Or ... it works for my (non incognito session) but not in this private window. 🦹‍♂️

[nelsonic]

According to the logs for the MVP App: https://fly.io/apps/mvp/monitoring

The failure is:

SELECT p0."person_id", p0."name", p0."inserted_at", p0."updated_at" FROM "people" AS p0 WHERE (p0."person_id" = $1) [142]

14:52:59.996 request_id=Fx1Z_OpPI33afeIAACRx [debug] Converted error Ecto.NoResultsError to 404 response

Looking up the person is what is breaking this request.
The person doesn't exist and therefore the session fails.

Let's fix this. 🛠️

[nelsonic]

To be clear: the MVP is still working for me in my main window:

So I had to go out of my way to see the issue. But it's definitely there for new people trying to use the MVP.

[SimonLab]

It looks like #174 (comment) is also the issue I've spotted #168
I've added a fix on the list PR #165 (comment)
I can extract this code to a new PR while list is being worked on.
In the future, I don't think we'll need this as the people table might be removed

[LuchoTurtle]

Github sign-in appears to be working now. Thank you!

[nelsonic]

@LuchoTurtle thank you for confirming you are able to login using GitHub. 🎉
Please proceed to: #140 🙏