Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible incorrect usage of getters in Extended Co-ordinate system. #44

Closed
kevaundray opened this issue Aug 24, 2020 · 1 comment
Closed
Labels
status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)

Comments

@kevaundray
Copy link

In the link below, there is a get_x, get_y, get_t1, get_t2 method.

If these methods are needed, consider having one function to return the tuple of coordinates as in the extended co-ordinate system a point cannot be uniquely identified solely by it's x or y co-ordinate.

This could cause possible bugs, where the API user gets x, expecting it to behave the same way as the Affine co-ordinate system.

https://github.com/dusk-network/jubjub/blob/c968497fba04a4e9afae6ff6c55ff0e7dbfd3a39/src/lib.rs#L583-605

@CPerezz
Copy link

CPerezz commented Sep 11, 2020

This goes inline with #41

I do agree that this can lead to bugs. At the same time the methods as you say are needed. We could add these functions behind a feature so that you need to add it and therefore are completely sure that you will take the risk.

@ZER0 ZER0 added team:Core Low Level Core Development Team (Rust) status:minor Low priority improvements and removed type:question labels Jan 15, 2021
@autholykos autholykos added team:R&D Research & Development (Cryptographic Protocol) and removed team:Core Low Level Core Development Team (Rust) labels Jul 1, 2021
@autholykos autholykos added team:Core Low Level Core Development Team (Rust) and removed team:R&D Research & Development (Cryptographic Protocol) labels Jul 20, 2021
@ZER0 ZER0 closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)
Projects
None yet
Development

No branches or pull requests

4 participants