Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Proxy support? #12

Open
bemar76 opened this issue Aug 25, 2021 · 15 comments
Open

Http Proxy support? #12

bemar76 opened this issue Aug 25, 2021 · 15 comments

Comments

@bemar76
Copy link

bemar76 commented Aug 25, 2021

Hello,

how can I get support for http proxy?
I did not find another way than having code changes in the sdk modul to get OkHttp to use proxy.

Thank you

Benjamin

@AaronAtDuo
Copy link
Contributor

@bemar76 We definitely have plans to add proxy support to this, as well as the other languages' Duo Universal clients. Unfortunately, that's not quite at the top of our priority list at the moment, so I can't give you a good estimate on when that might happen.

@bemar76
Copy link
Author

bemar76 commented Aug 26, 2021

@AaronAtDuo
I've implemented it already because we have a proxy infrastructure in our company. If your are interested for the code, let me know.

@AaronAtDuo
Copy link
Contributor

@bemar76 We'd definitely be interested! If you've got a fork with the change, or want to put together a PR, etc. we'd definitely take a look.

@bemar76
Copy link
Author

bemar76 commented Oct 5, 2021

Hallo Aaron,

you can find my approach here

https://github.com/bemar76/duo_universal_java/

Sorry for choosing wrong character set.

@AaronAtDuo
Copy link
Contributor

I'll take a look! We'll see when we can get proxy support prioritized. It'll probably be after we add a couple more languages though.

Thanks for the note.

@LMCO-Richard
Copy link

@AaronAtDuo @bemar76 I don't see a pull request was made. @bemar76 code with proxy added works for me. Can we make a pull request and get this added?

@LMCO-Richard
Copy link

LMCO-Richard commented Aug 11, 2022

@AaronAtDuo Also, could you please upgrade the com.auth0.java-jwt dependency to the latest version as one of its transitive dependencies Apache Commons Codec introduces breakage with new versions of Apache Commons Codec. In the latest version of com.auth0.java-jwt, the transitive dependency Apache Commons Codec has been removed.

@AaronAtDuo
Copy link
Contributor

@LMCO-Richard I'll see what I can do. It looks like in the latest version (4.0.0) they changed the signature of something we use, so it's not a simple pom-only update...

@AaronAtDuo
Copy link
Contributor

Ok #19 is in for the dependency update, fingers crossed that it passes CI.

@AaronAtDuo
Copy link
Contributor

@LMCO-Richard Commit 0febdbf updates the JWT library dependency.

HTTP proxy support might take a bit longer - do you want to wait for that, or should I do a release with just the dependency change?

@LMCO-Richard
Copy link

@AaronAtDuo Thank you for addressing the dependency issue. Yes, I'd like to wait for the HTTP proxy support. I believe it should be pretty straightforward as @bemar76 already has all the required code changes in his repo. Thanks again!

@bemar76
Copy link
Author

bemar76 commented Oct 10, 2022

You're welcome. Proud do have some of my code inside this amazing project.

@eosmith eosmith mentioned this issue Oct 25, 2023
3 tasks
@eosmith
Copy link
Contributor

eosmith commented Oct 27, 2023

@AaronAtDuo I've incorporated the http proxy server support from the excellent fork by @bemar76 into my own fork from the the most recent version of this project and submitted a pull request. Our team at Carnegie Mellon would greatly appreciate it if Duo would approve this request so we don't have to maintain a separate project from yours that offers proxy server support. It appears from the comments that others would benefit as well. Thank you for your consideration.

@AaronAtDuo
Copy link
Contributor

@eosmith I definitely plan to look this over and try to get it merged next week.

@litesam
Copy link

litesam commented Apr 26, 2024

Hey Aaron, I am also facing this issue when can we expect the proxy support.

In the meantime do you have any alternative way to configure the proxy to the Duo client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants