Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to the most recent version of duckdb submodule #7

Merged
merged 9 commits into from
Jul 10, 2024

Conversation

hmeriann
Copy link
Contributor

@hmeriann hmeriann commented Jul 2, 2024

This PR pushes a new submodule pointer in the sqlsmith_smith repository as described here

@hmeriann
Copy link
Contributor Author

hmeriann commented Jul 2, 2024

@Tmonster please take a look. I tried to compile and to run tests - everything worked.

Copy link
Collaborator

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, would like to know first is @samansmink has any concerns (I've never done this before and would like to not break CI or the extension ecosystem)

@samansmink
Copy link

I think its fine, basically and extension can either track latest stable, or like sqlsmith is doing now, main. tracking main is a little more confusing because ci might choose a different version than is in the submodule because they are not tied to eachother in any way. The submodule version is currently only used for development.

Note that some extensions do actually use the submodule version in CI, for example: https://github.com/duckdb/duckdb_iceberg/blob/main/.github/workflows/Rest.yml.

@Tmonster
Copy link
Collaborator

Tmonster commented Jul 3, 2024

@hmeriann can you check that the extension ci tools are also set to the latest duckdb version? v1.0.0?
Then I think this is good to merge.

@samansmink all other references to a duckdb stable version should reference v1.0.0 so I think this will be fine

@hmeriann
Copy link
Contributor Author

hmeriann commented Jul 3, 2024

@Tmonster sure, I'll check it

@Tmonster Tmonster merged commit da0983f into duckdb:main Jul 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants