From 4545b443b61a0ee9bf746356e385eee744f06095 Mon Sep 17 00:00:00 2001
From: Peter <boncz@dhcp-12.eduroam.cwi.nl>
Date: Tue, 10 Oct 2023 17:49:09 +0200
Subject: [PATCH] add some std::move() to appease the arm Linux compiler

---
 src/iceberg_functions/iceberg_metadata.cpp  | 4 ++--
 src/iceberg_functions/iceberg_scan.cpp      | 4 ++--
 src/iceberg_functions/iceberg_snapshots.cpp | 8 ++++----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/iceberg_functions/iceberg_metadata.cpp b/src/iceberg_functions/iceberg_metadata.cpp
index 12f0dd9..cd8e770 100644
--- a/src/iceberg_functions/iceberg_metadata.cpp
+++ b/src/iceberg_functions/iceberg_metadata.cpp
@@ -90,7 +90,7 @@ static unique_ptr<FunctionData> IcebergMetaDataBind(ClientContext &context, Tabl
 	auto manifest_entry_names = IcebergManifestEntry::Names();
 	names.insert(names.end(), manifest_entry_names.begin(), manifest_entry_names.end());
 
-	return ret;
+	return std::move(ret);
 }
 
 static unique_ptr<FunctionData> IcebergScanBind(ClientContext &context, TableFunctionBindInput &input,
@@ -159,4 +159,4 @@ TableFunctionSet IcebergFunctions::GetIcebergMetadataFunction() {
 	return function_set;
 }
 
-} // namespace duckdb
\ No newline at end of file
+} // namespace duckdb
diff --git a/src/iceberg_functions/iceberg_scan.cpp b/src/iceberg_functions/iceberg_scan.cpp
index 9880564..3459cce 100644
--- a/src/iceberg_functions/iceberg_scan.cpp
+++ b/src/iceberg_functions/iceberg_scan.cpp
@@ -108,7 +108,7 @@ static unique_ptr<TableRef> MakeScanExpression(vector<Value> &data_file_values,
 		vector<unique_ptr<ParsedExpression>> left_children;
 		left_children.push_back(make_uniq<ConstantExpression>(Value::LIST(data_file_values)));
 		table_function_ref_data->function = make_uniq<FunctionExpression>("parquet_scan", std::move(left_children));
-		return table_function_ref_data;
+		return std::move(table_function_ref_data);
 	}
 
 	// Join
@@ -250,4 +250,4 @@ TableFunctionSet IcebergFunctions::GetIcebergScanFunction() {
 	return function_set;
 }
 
-} // namespace duckdb
\ No newline at end of file
+} // namespace duckdb
diff --git a/src/iceberg_functions/iceberg_snapshots.cpp b/src/iceberg_functions/iceberg_snapshots.cpp
index 966f93a..76fa390 100644
--- a/src/iceberg_functions/iceberg_snapshots.cpp
+++ b/src/iceberg_functions/iceberg_snapshots.cpp
@@ -32,7 +32,7 @@ struct IcebergSnapshotGlobalTableFunctionState : public GlobalTableFunctionState
 		global_state->iceberg_format_version = IcebergUtils::TryGetNumFromObject(root, "format-version");
 		auto snapshots = yyjson_obj_get(root, "snapshots");
 		yyjson_arr_iter_init(snapshots, &global_state->snapshot_it);
-		return global_state;
+		return std::move(global_state);
 	}
 
 	string metadata_file;
@@ -59,7 +59,7 @@ static unique_ptr<FunctionData> IcebergSnapshotsBind(ClientContext &context, Tab
 	names.emplace_back("manifest_list");
 	return_types.emplace_back(LogicalType::VARCHAR);
 
-	return bind_data;
+	return std::move(bind_data);
 }
 
 // Snapshots function
@@ -90,7 +90,7 @@ TableFunctionSet IcebergFunctions::GetIcebergSnapshotsFunction() {
 	TableFunction table_function({LogicalType::VARCHAR}, IcebergSnapshotsFunction, IcebergSnapshotsBind,
 	                             IcebergSnapshotGlobalTableFunctionState::Init);
 	function_set.AddFunction(table_function);
-	return function_set;
+	return std::move(function_set);
 }
 
-} // namespace duckdb
\ No newline at end of file
+} // namespace duckdb