Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two rules which are essentially the same ? #44

Open
jrfnl opened this issue May 26, 2015 · 2 comments
Open

Two rules which are essentially the same ? #44

jrfnl opened this issue May 26, 2015 · 2 comments

Comments

@jrfnl
Copy link

jrfnl commented May 26, 2015

When going through everything, I noticed that these two are essentially the same. If they are not (supposed to be), then maybe the difference between the two rules should be made clearer.
If they are, I suggest merging them into one rule.

https://github.com/dseguy/clearPHP/blob/master/rules/no-buried-assignation.md
https://github.com/dseguy/clearPHP/blob/master/rules/no-implied-if.md

@jrfnl
Copy link
Author

jrfnl commented May 26, 2015

Reading through them again, I do see them as two different rules, but the distinction could still be made clearer.

@dseguy
Copy link
Owner

dseguy commented May 27, 2015

Implied-if is for using && or || as a if-then-else statement.
buried assignation is for locating an assignation where one would expect only an argument.

Do you have suggestions for renaming ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants