From d58282a35e3a8d5f649457ae2173ebc95352bf4e Mon Sep 17 00:00:00 2001 From: Yvan Duhamel Date: Fri, 14 Jan 2022 16:52:33 +0100 Subject: [PATCH] improve tests and increase code coverage --- ...Dsc.SPTrustedIdentityTokenIssuer.Tests.ps1 | 42 ++++++++++++++----- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/tests/Unit/SharePointDsc/SharePointDsc.SPTrustedIdentityTokenIssuer.Tests.ps1 b/tests/Unit/SharePointDsc/SharePointDsc.SPTrustedIdentityTokenIssuer.Tests.ps1 index cdcbe35c6..f375c790b 100644 --- a/tests/Unit/SharePointDsc/SharePointDsc.SPTrustedIdentityTokenIssuer.Tests.ps1 +++ b/tests/Unit/SharePointDsc/SharePointDsc.SPTrustedIdentityTokenIssuer.Tests.ps1 @@ -569,19 +569,30 @@ try } Mock -CommandName Get-SPTrustedIdentityTokenIssuer -MockWith { + return $null + } + + Mock -CommandName New-SPTrustedIdentityTokenIssuer -MockWith { $sptrust = [pscustomobject]@{ - Name = $testParams.Name - ClaimProviderName = $testParams.ClaimProviderName + ImportTrustCertificate = $null + Name = "" + Description = "" + Realm = "" + SignInUrl = "" + UseWReply = "" + ProviderSignOutUri = "" + IdentifierClaim = "" + ClaimsMappings = $null + ClaimProviderName = "" } $sptrust | Add-Member -Name Update -MemberType ScriptMethod -Value { } return $sptrust } } - It "Should create the SPTrustedLoginProvider with claims provider set" { + It "Should call cmdlet New-SPTrustedIdentityTokenIssuer" { Set-TargetResource @testParams - $getResults = Get-TargetResource @testParams - $getResults.ClaimProviderName | Should -Be $testParams.ClaimProviderName + Assert-MockCalled New-SPTrustedIdentityTokenIssuer } } @@ -615,19 +626,30 @@ try } Mock -CommandName Get-SPTrustedIdentityTokenIssuer -MockWith { + return $null + } + + Mock -CommandName New-SPTrustedIdentityTokenIssuer -MockWith { $sptrust = [pscustomobject]@{ - Name = $testParams.Name - ClaimProviderName = $testParams.ClaimProviderName + ImportTrustCertificate = $null + Name = "" + Description = "" + RegisteredIssuerName = "" + AuthorizationEndPointUri = "" + DefaultClientIdentifier = "" + SignOutUrl = "" + IdentifierClaim = "" + ClaimsMappings = $null + ClaimProviderName = "" } $sptrust | Add-Member -Name Update -MemberType ScriptMethod -Value { } return $sptrust } } - It "Should create the SPTrustedLoginProvider with claims provider set" { + It "Should call cmdlet New-SPTrustedIdentityTokenIssuer" { Set-TargetResource @testParams - $getResults = Get-TargetResource @testParams - $getResults.ClaimProviderName | Should -Be $testParams.ClaimProviderName + Assert-MockCalled New-SPTrustedIdentityTokenIssuer } } }