Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no file is given, download all assets #54

Open
lumpidu opened this issue Apr 13, 2023 · 1 comment
Open

If no file is given, download all assets #54

lumpidu opened this issue Apr 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lumpidu
Copy link

lumpidu commented Apr 13, 2023

The error is somewhat misleading, if no file: key is given:

/home/runner/work/_actions/dsaltares/fetch-gh-release-asset/master/dist/index.js:2050
        throw new Error(`Input required and not supplied: ${name}`);

I rather supposed that all files would be downloaded in that case. I know that the Readme states that this parameter is required, but leaving it out would be the most intuitive way to say: download all files from a release. Or do you have a better proposal ?

@dsaltares dsaltares added the enhancement New feature or request label Apr 20, 2023
@dsaltares
Copy link
Owner

dsaltares commented Apr 20, 2023

I think the README is pretty clear saying the option is required although I understand you may want to download all files. You can achieve that by enabling the regex option and passing a regex to file that will accept all possible file names: .*.

In any case, I will leave this issue open as an enhacement to make file optional and have the behaviour you described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants