Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DruxtMenu #537

Open
2 tasks
Decipher opened this issue Jul 18, 2022 · 0 comments
Open
2 tasks

Refactor DruxtMenu #537

Decipher opened this issue Jul 18, 2022 · 0 comments
Labels
enhancement New feature or request module: menu Related to the `druxt-menu` module
Milestone
1.1.0

Comments

@Decipher
Copy link
Member

Decipher commented Jul 18, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently the DruxtMenu module component has a large number of style based props, overcomplicating the functionality.

As a developer I want to refactor the DruxtMenu module component to make it easier to use.

Describe the solution you'd like

  • Remove style based props, that can be dealt with in the theme component / default template inject.
  • Ensure client based props only to ensure the module can easily retrieve the required data.

Describe alternatives you've considered
N/A

Additional context
N/A
@Decipher Decipher mentioned this issue Jul 18, 2022
Closed
9 tasks
@Decipher Decipher changed the title DruxtMenu: depth, maxDepth, minDepth, name & parentId Refactor DruxtMenu Jul 18, 2022
@Decipher Decipher added this to the 1.1.0 milestone Jul 18, 2022
@Decipher Decipher added module: menu Related to the `druxt-menu` module enhancement New feature or request labels Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module: menu Related to the `druxt-menu` module
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@Decipher