Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests. Add config variable with settings #8

Open
2 of 3 tasks
vladdancer opened this issue Jul 4, 2016 · 1 comment
Open
2 of 3 tasks

Fix integration tests. Add config variable with settings #8

vladdancer opened this issue Jul 4, 2016 · 1 comment
Assignees
@vladdancer
Labels
2 - Working <= 5 bug testing
Milestone
a developer ready...

Comments

@vladdancer
Copy link
Member

vladdancer commented Jul 4, 2016 •
edited
Loading

  • Do a rollback to this throw new \RuntimeException
  • Add $config to settings.php or settings.local.php
  • make throw new \RuntimeException return non-zero code
@vladdancer vladdancer self-assigned this Jul 4, 2016
@vladdancer
Copy link
Member Author

vladdancer commented Jul 4, 2016 •
edited
Loading

We should do a rollback this throw new \RuntimeException

Currently we have.

file_put_contents('php://stderr', $message);
exit(1);

Until we add
http://stackoverflow.com/questions/10520390/stop-script-execution-upon-notice-warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladdancer vladdancer

Labels
2 - Working <= 5 bug testing
Projects
None yet
Milestone
a developer ready tested version 1
Development

No branches or pull requests
1 participant
@vladdancer