-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow schema caching per server when using a common base schema #1224
base: 8.x-4.x
Are you sure you want to change the base?
Conversation
See #1223 for initial notes |
I'm sorry, I went to try and create a test to demonstrate this but it's completely beyond me. |
Ok, now this PR contains a potential fix using a setter on the plugin to provide the server ID. We could probably also do it by putting another key on the configuration that gets passed to the plugin but this seemed safer to me. |
Alright I give up. The last test failure is a conflict between PHPStan and phpcs PHPStan:
phpcs:
|
Co-authored-by: Alexander Varwijk <[email protected]>
Co-authored-by: Alexander Varwijk <[email protected]>
I am NOT by any means suggesting this at the fix approach, it merely shows where the problem lies so a discussion can be had regarding how to fix it.Updated to a viable patch, though there are other ways we could approach it.