Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change super() to super(Connection, self) for python2 and 3 #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mxins
Copy link

@mxins mxins commented Jul 28, 2021

change super() to super(Connection, self), super() does not work in python2

@mxins
Copy link
Author

mxins commented Jul 28, 2021

pyhive/trino.py line 51:
class Connection(PrestoConnection):
def init(self, *args, **kwargs):
super(Connection, self).init(*args, **kwargs):

@mxins mxins changed the title change super() to super(Connection, self) for python2 change super() to super(Connection, self) for python2 and 3 Jul 28, 2021
Copy link

@byungnam byungnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py2 code need this.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


meixinsheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants