Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import iterable from collection.abc instead of collections to clear deprecation warning in python 3.10 #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

import iterable from collection.abc instead of collections to clear deprecation warning in python 3.10 #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pyhive/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,15 @@
from past.builtins import basestring
from pyhive import exc
import abc
import collections
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file still uses deque from collections at

PyHive/pyhive/common.py

Line 41 in d6e7140

self._data = collections.deque()
. This import should not be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted to "import collections" and changed import at Iterable statement as collections.abc.Iterable

import time
import datetime
from future.utils import with_metaclass
from itertools import islice

try:
from collections.abc import Iterable
except ImportError:
from collections import Iterable
from collections import deque

class DBAPICursor(with_metaclass(abc.ABCMeta, object)):
"""Base class for some common DB-API logic"""
Expand All @@ -38,7 +41,7 @@ def _reset_state(self):

# Internal helper state
self._state = self._STATE_NONE
self._data = collections.deque()
self._data = deque()
self._columns = None

def _fetch_while(self, fn):
Expand Down Expand Up @@ -245,7 +248,7 @@ def escape_item(self, item):
return self.escape_number(item)
elif isinstance(item, basestring):
return self.escape_string(item)
elif isinstance(item, collections.Iterable):
elif isinstance(item, Iterable):
return self.escape_sequence(item)
elif isinstance(item, datetime.datetime):
return self.escape_datetime(item, self._DATETIME_FORMAT)
Expand Down