Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mariadb support, versions, add display names, fix circleci testing #14

Open
wants to merge 124 commits into
base: master
Choose a base branch
from

Conversation

eddiewebb
Copy link

This is basically shoving 4 downstream forks and ~60 commits IN CASE original maintainer/author cares to keep this hobbling along.

Copy link
Author

@eddiewebb eddiewebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at all the chamnges the version checks were ripped out entirely, will need to reintroduce and make sure displayname support and any other changes aloign.

return ErrIredMailVersionNotSupported
}

//TODO use version.EASY boolean to check semver style or new easy date tag style
return nil
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops lol, not sute where that was introduced, ill work on unwinding and adding easy and standard version config

)

var (
// ErrIredMailVersionNotSupported ...
ErrIredMailVersionNotSupported = errors.New("iredMail version is not supported")
)

type iredMailVersion string
type iredMailVersion struct {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allows distinction of new 'easy' versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants