-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mariadb support, versions, add display names, fix circleci testing #14
base: master
Are you sure you want to change the base?
Conversation
Update mailboxAdd.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at all the chamnges the version checks were ripped out entirely, will need to reintroduce and make sure displayname support and any other changes aloign.
return ErrIredMailVersionNotSupported | ||
} | ||
|
||
//TODO use version.EASY boolean to check semver style or new easy date tag style | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops lol, not sute where that was introduced, ill work on unwinding and adding easy and standard version config
) | ||
|
||
var ( | ||
// ErrIredMailVersionNotSupported ... | ||
ErrIredMailVersionNotSupported = errors.New("iredMail version is not supported") | ||
) | ||
|
||
type iredMailVersion string | ||
type iredMailVersion struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows distinction of new 'easy' versions
This is basically shoving 4 downstream forks and ~60 commits IN CASE original maintainer/author cares to keep this hobbling along.