Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set split proportions to None if split column is provided - Issue #198 #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sambujangfofana
Copy link

Per #198,

@aaronphilip19 and I implemented this by defining the default split_proporitions values. We then added a check to see if the provided split column is equal to the default values. If they are not equal, “Labels contains split column yet split_proportions are also provided. Split column in labels takes precedence.” is prompted and split_proportions is set to None.

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for silly-keller-664934 ready!

Name Link
🔨 Latest commit 69405a7
🔍 Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/662c09a3a44a440008829b88
😎 Deploy Preview https://deploy-preview-323--silly-keller-664934.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant