Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error from type annotations containing ellipsis #127

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Sep 14, 2024

Fix runtime AttributeError for type annotations with ellipsis literal (e.g., tuple[int, ...]).

Closes #124.

Copy link
Contributor

github-actions bot commented Sep 14, 2024

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.4%. Comparing base (e77348e) to head (0b334a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #127   +/-   ##
=====================================
  Coverage   98.4%   98.4%           
=====================================
  Files         19      19           
  Lines        819     821    +2     
=====================================
+ Hits         806     808    +2     
  Misses        13      13           
Files with missing lines Coverage Δ
erdantic/core.py 97.6% <100.0%> (+<0.1%) ⬆️

@jayqi jayqi merged commit 3464382 into main Sep 19, 2024
17 checks passed
@jayqi jayqi deleted the 124-fix-ellipsis branch September 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model detection fails for Ellipsis
1 participant