-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3 fake directory fix #206
s3 fake directory fix #206
Conversation
GeorgeSabu
commented
Feb 6, 2022
•
edited
Loading
edited
- Have fixed the fake s3 directory bug
- Have fixed the test cases
- Added some content to the file in the assets folder in test so that file size is not zero
- Also fixed some warning that are coming while running test cases
@pjbull I have updated |
@pjbull There is a |
@GeorgeSabu the error is from #203 |
@jayqi oops didnt know about it. I did an empty commit to rerun the test to make sure its not some other thing. Thanks for the info. |
Another thing to note here is that we've made some changes to Additionally, some comments about the changes:
|
* [WIP]: taking care of the corner case folder created from S3 * Fix format issues * [WIP]:updated test case for the s3 file directory test * removed the linting issue * Empty commit to rerun the test cases Co-authored-by: Sabu George <[email protected]>
@jayqi As far as I understood the code the function
Now 'test-folder/' behaves likes an object than a prefix. And as By checking the Size > 0 I am making sure that this recursion does not happen. I hope this clears. |