Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob broken on Python 3.7 #413

Closed
Quickblink opened this issue Mar 2, 2024 · 1 comment
Closed

glob broken on Python 3.7 #413

Quickblink opened this issue Mar 2, 2024 · 1 comment

Comments

@Quickblink
Copy link

PR #202 introduced using pathlib internals for the glob implementation which make use of the scandir function as a contextlib.contextmanager. Apparently, pathlib used to work differently (expecting scandir to be an iterator directly) before 3.8 so glob essentially doesn’t work for older python versions. I would suggest dropping support as 3.7 has reached end-of-life status.

@pjbull
Copy link
Member

pjbull commented Mar 2, 2024

I think this is a dupe of #210, not all 3.7.

0.18.1 is already our last 3.7 supporting release:
https://github.com/drivendataorg/cloudpathlib/blob/master/HISTORY.md?plain=1#L13

@pjbull pjbull closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants