Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floatingMaker order cancelation behavior #66

Open
ricardojmendez opened this issue Sep 4, 2023 · 0 comments
Open

floatingMaker order cancelation behavior #66

ricardojmendez opened this issue Sep 4, 2023 · 0 comments

Comments

@ricardojmendez
Copy link
Contributor

On the floatingMaker bot, it looks like the open orders for a given market are canceled only if one has been fully filled.

if (
(openOrders.length > 0 && openOrders.length != 2) ||
marketIndex === 0
) {

This makes sense if the idea is to avoid placing new orders if the market hasn't fully hit one of our ranges. However, it always cancels the orders for SOL-PERP.

What's the rationale?

ricardojmendez added a commit to ricardojmendez/keeper-bots-v2 that referenced this issue Sep 5, 2023
The bot was canceling existing orders when one side had been fully
filled, *except* for SOL-PERP, in which case it always canceled them
even if they were partially filled. This had the effect that a SOL_PERP
position grew rapidly unbalanced, regardless of how much the market
was moving.

See issue drift-labs#66.
ricardojmendez added a commit to ricardojmendez/keeper-bots-v2 that referenced this issue Sep 6, 2023
The bot was canceling existing orders when one side had been fully
filled, *except* for SOL-PERP, in which case it always canceled them
even if they were partially filled. This had the effect that a SOL_PERP
position grew rapidly unbalanced, regardless of how much the market
was moving.

See issue drift-labs#66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant