better battery indication for charging from AC #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like your idea, however it seems as if the new character is partially overlapping with the character that follows. |
|
macOS: fully charged Linux: charging Linux: discharging
|
|
awesome! any clue why linux has no percent symbol? seems like that needs fixing (not trying to say that it was you). |
|
The master branch is also missing the "%" symbol. I will prepare a fix in a separate PR.
|
|
cool :D |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #276.
However, the icons for charging from AC have been replaced with a single-symbol icon instead of two symbols for better visibility.