Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groundwork still calculated to do half efficiency when under Waste Not I/II with less than 20 durability left #410

Open
Drakonas opened this issue Aug 31, 2020 · 2 comments

Comments

@Drakonas
Copy link

Drakonas commented Aug 31, 2020

Required Information

Class: LTW (Applies to all)
Level: 80 (N/A)
Craftsmanship: 2603 (N/A)
Control: 2639 (N/A)
CP:528 (N/A)
Recipe Name: Sea Swallow Leather (Applies to all)
Recipe Level: 78 (Applies to all)
Solver Seed: 192502. I created my own macro using the simulator, and the issue can be shown there.

Expected Behaviour

Using Groundwork under Waste Not II/I while in-game, when at 10 durability or higher, will still count the full 300% progress efficiency.

I can use this macro successfully. I can prove a 150% efficiency only goes to 1111/1822, if you replace the Groundwork with a Careful Synthesis. Groundwork, however, counts the full 300% with Waste Not II, and finishes the craft with the full 1822 progress.

Actual Behaviour

The solver/simulator thinks Groundwork still needs 20 durability to hit the 300% efficiency, even though the simulator solver does show that it only uses 10 durability during the craft. The progress is shown to only meet 1111/1822 progress in the solver.

Steps To Reproduce

Nothing different from default. Just these stats. No food or buffs. I created a rotation myself, and the issue is prevalent. I am not sure if this is being used in calculations for creating macros, but it very well might be and it would DEFINITELY negatively affect craft success with the solver.

@Drakonas Drakonas changed the title Groundwork still calculated to need 20 durability for 300% efficiency even when under Waste Not I/II Groundwork still calculated to do half efficiency even when under Waste Not I/II with less than 20 durability left Aug 31, 2020
@Drakonas Drakonas changed the title Groundwork still calculated to do half efficiency even when under Waste Not I/II with less than 20 durability left Groundwork still calculated to do half efficiency when under Waste Not I/II with less than 20 durability left Aug 31, 2020
@dten
Copy link

dten commented Sep 1, 2020

i fixed this in #406 but it's waiting to be merged

@Drakonas
Copy link
Author

Drakonas commented Sep 1, 2020

My apologies. Thanks for the headsup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants