Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport WinFX changes to "v3.1" and "v5.0" SDKs #4253

Closed
Nirmal4G opened this issue Mar 7, 2021 · 4 comments
Closed

Backport WinFX changes to "v3.1" and "v5.0" SDKs #4253

Nirmal4G opened this issue Mar 7, 2021 · 4 comments
Assignees
@ryalanms
Labels
Investigate Requires further investigation by the WPF team.

Comments

@Nirmal4G
Copy link
Contributor

Nirmal4G commented Mar 7, 2021 •
edited
Loading

Can we backport WinFX changes from PRs (#2975, #2976, #4629, #4630) into v3.1 and v5.0 SDKs?

These changes (casing fix and double-import fix) shouldn't be high-risk change when all they do is fix some issues that were most common and frustrating to work around (at least in our case). I have checked with both patched SDKs from our side and v6.0 preview SDKs. They don't cause no major issues.

I already have the patches available targeting both v3.1 and v5.0 branches. It would be very helpful if the team could look this at priority. We thought we could wait until v6.0 releases but our build requires these two changes immediately. Having to apply the workaround on our CI while build is really a recipe for disaster.
This was referenced Mar 7, 2021
Closed
Closed
@ryalanms ryalanms self-assigned this Mar 15, 2021
@ryalanms ryalanms added Investigate Requires further investigation by the WPF team. and removed Requires WPF team triage labels Mar 15, 2021
@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented Apr 2, 2021

@ryalanms Any update on this?

@Nirmal4G
Copy link
Contributor Author

@ryalanms The PRs were already opened. If possible, please take a look, at priority. I would really appreciate it, if these patches get merged!!

@Nirmal4G
Copy link
Contributor Author

Nirmal4G commented Jun 8, 2021

@ryalanms @vatsan-madhavan 🔔

@ryalanms ryalanms added this to the Future milestone Sep 2, 2021
@Nirmal4G
Copy link
Contributor Author

The .NET SDKs v3.1 and v5.0 are now out of support and superseded by v6.0+ SDKs.

@Nirmal4G Nirmal4G closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed this from the Future milestone Jul 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryalanms ryalanms

Labels
Investigate Requires further investigation by the WPF team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nirmal4G @ryalanms