Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenAI] Add Mistral 7B Instruction V0.3 #7231

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

LittleLittleCloud
Copy link
Contributor

@LittleLittleCloud LittleLittleCloud commented Sep 3, 2024

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

#7169

await agent.SendAsync(task);
}

public static void Embedding()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisquintanilla This will be how bge-en-icl embedding model consumed.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 363 lines in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (87a41fa) to head (05f726d).

Files with missing lines Patch % Lines
...Microsoft.ML.GenAI.Mistral/MistralCausalLMAgent.cs 0.00% 98 Missing ⚠️
src/Microsoft.ML.GenAI.Mistral/MistralModel.cs 18.75% 76 Missing and 2 partials ⚠️
.../Microsoft.ML.GenAI.Mistral/MistralDecoderLayer.cs 28.57% 65 Missing ⚠️
...c/Microsoft.ML.GenAI.Mistral/MistralForCausalLM.cs 12.30% 57 Missing ⚠️
...GenAI.Mistral/Mistral_7B_0_3ChatTemplateBuilder.cs 76.19% 15 Missing and 15 partials ⚠️
...crosoft.ML.GenAI.Core/Pipeline/CausalLMPipeline.cs 0.00% 14 Missing ⚠️
...crosoft.ML.GenAI.Mistral/MistralTokenizerHelper.cs 80.00% 6 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Mistral/MistralMLP.cs 64.70% 6 Missing ⚠️
...nAI.Mistral.Tests/Mistral_7B_Instruct_V0_3Tests.cs 95.45% 3 Missing and 1 partial ⚠️
src/Microsoft.ML.GenAI.Core/Utils.cs 66.66% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7231      +/-   ##
==========================================
- Coverage   68.83%   68.78%   -0.05%     
==========================================
  Files        1453     1461       +8     
  Lines      271562   272208     +646     
  Branches    28094    28168      +74     
==========================================
+ Hits       186933   187246     +313     
- Misses      77410    77722     +312     
- Partials     7219     7240      +21     
Flag Coverage Δ
Debug 68.78% <47.61%> (-0.05%) ⬇️
production 63.29% <40.66%> (-0.06%) ⬇️
test 89.04% <95.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...soft.ML.GenAI.LLaMA/Llama3_1ChatTemplateBuilder.cs 68.62% <ø> (ø)
src/Microsoft.ML.GenAI.LLaMA/LlamaCausalLMAgent.cs 0.00% <ø> (ø)
src/Microsoft.ML.GenAI.LLaMA/Module/LlamaModel.cs 18.75% <ø> (ø)
src/Microsoft.ML.GenAI.Phi/Phi2/Config.cs 98.00% <100.00%> (ø)
src/Microsoft.ML.GenAI.Phi/Phi3/Config.cs 93.84% <100.00%> (ø)
...c/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMAgent.cs 56.71% <ø> (ø)
src/Microsoft.ML.GenAI.Phi/Utils.cs 0.00% <ø> (-8.11%) ⬇️
src/Microsoft.ML.GenAI.Mistral/MistralConfig.cs 97.95% <97.95%> (ø)
src/Microsoft.ML.GenAI.Core/Utils.cs 12.94% <66.66%> (+6.36%) ⬆️
...nAI.Mistral.Tests/Mistral_7B_Instruct_V0_3Tests.cs 95.45% <95.45%> (ø)
... and 8 more

... and 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants