Tests: clean-up unneeded code #17762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
|
Yeah!!! the tests are probably not as consistent as you think. Different tests, even within the ComponentTests suite have different strategies ... usually depending on how the test originally work. |
|
I think I had that special case handled for that |
|
Yes it's like geological strata, sediments upon sediments. But it seems this worked :) |
|
Yeah. We are doing geological programming this week :) Consider conducting some smoke testing from whatever applies in this comment to a sibling PR - among other things, doing this will just help us "compile" some sanity checks for these sorts of PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tests run in temp directories by default, this code in
single-test.fsshould no longer be needed.Let's see if it is.