Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix missing MSTestNamespaces.txt in output dir #233

Closed
wants to merge 1 commit into from
Closed

Fix missing MSTestNamespaces.txt in output dir #233

wants to merge 1 commit into from

Conversation

gabrielweyer
Copy link

MSTestNamespaces.txt should be copied to output directory if we want to use the tool from command line.

Fix #232

MSTestNamespaces.txt should be copied to output directory if we want to use the tool from command line.

Fix #232
@tiesmaster
Copy link

Is there any chance of this PR getting merged? I ran into this issue a couple months ago, and finally found this PR that fixed it for me, and I think issue #246 is caused by this as well.

@tiesmaster
Copy link

@jaredpar Seeing you've merged #249, now that this project seems alive again, then you might also consider merging this one, since it solves #246, for example.

@ericstj ericstj closed this Mar 11, 2021
@ericstj ericstj deleted the branch dotnet:master March 11, 2021 16:44
@gabrielweyer
Copy link
Author

May I know why this was closed? Looking at src/XUnitConverter/XUnitConverter.csproj it appears the issue is still present.

@ericstj
Copy link
Member

ericstj commented Mar 19, 2021

Looks like GitHub auto-closed it when the branch was renamed. I didn't directly close it. Unfortunately GitHub doesn't let me reopen it. Let me see if I can recreate the PR.

@ericstj
Copy link
Member

ericstj commented Mar 19, 2021

Is it possible you deleted the forked repo? I'm not seeing the branch this PR was based off of anywhere: gabrielweyer:fix-missing-ms-test-namespaces-file. That could be why Github closed the PR. I see others were repointed to main.

@gabrielweyer
Copy link
Author

Yes you're right, very likely that I deleted my fork. It wasn't listed in my repositories. I created Pull Request #293 as it seemed easier than attempting to fix this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants