Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display telemetry actions when no telemetry #6568

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 31, 2024

Description

Before: If a resource doesn't have telemetry then display disabled telemetry menu items
After: If a resource doesn't have telemetry then don't display telemetry menu items

telemetry-menu-items

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK enabled auto-merge (squash) October 31, 2024 06:06
@JamesNK
Copy link
Member Author

JamesNK commented Oct 31, 2024

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11607051830

@JamesNK JamesNK merged commit 34d6aab into main Oct 31, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/hide-telemetry-actions branch October 31, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants